This does not mess up iCloud devices, the [device is getting the name from the router and reporting it][1]. As soon as you rename the device or fix the network to assign a different name, iCloud will reflect the current names quickly. 

- - - -

It definitely is made worse by [YazFi][2], because since I uninstalled it from my router, all my devices have kept their names. I'm going to ask its developer also. This can happen on any network, however with [bonjour sleep proxy and dns/dhcp not cleaning old records][3] at the same rate as iOS devices reconnect after sleep. 

 YazFi's developer had asked people to reply to a thread in SmallNetBuilders forum regarding any issues. Several others created accounts there, but looks new users need to gain a few points to be able to post on the forums (similar to how new users can’t comment here without reputation or make edits without approval).

Getting enough momentum posting on SNB forums to link to this question might help others see it. 

[Editors note: this answer came from edits to the question so I moved it to the answer. I encourage others to put up a better answer or edit this as needed.][4]


  [1]: https://apple.stackexchange.com/questions/55416/my-mac-minis-computer-name-keeps-changing-when-it-resumes-from-sleep
  [2]: https://www.snbforums.com/threads/yazfi-enhanced-asuswrt-merlin-guest-wifi-inc-ssid-vpn-client.45924/
  [3]: https://apple.stackexchange.com/a/301258/5472
  [4]: https://apple.stackexchange.com/posts/387311/revisions